Skip to content

Call log_process_action to get the right status code (devise) #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quentindemetz wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Call log_process_action to get the right status code (devise) #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/lograge/log_subscribers/action_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
# frozen_string_literal: true

require 'action_controller'

module Lograge
module LogSubscribers
class ActionController < Base
def process_action(event)
::ActionController::Base.log_process_action(event.payload)
process_main_event(event)
end

Expand Down
9 changes: 9 additions & 0 deletions spec/log_subscribers/action_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,15 @@
end
end

context 'with a status code that is set in log_process_action (devise)' do
it 'returns the correct status code' do
allow(::ActionController::Base).to receive(:log_process_action) { |payload| payload[:status] = 401 }
event.payload[:status] = nil
subscriber.process_action(event)
expect(log_output.string).to match(/status=401 /)
end
end

it "will fallback to ActiveSupport's logger if one isn't configured" do
Lograge.formatter = Lograge::Formatters::KeyValue.new
Lograge.logger = nil
Expand Down