Merged
Conversation
thearturca
force-pushed
the
refactor/audio-system
branch
from
14b0cfb to
f96a6cd
Compare
thearturca
force-pushed
the
refactor/audio-system
branch
2 times, most recently
from
6f4cc75 to
0079bdb
Compare
Sometime only for one fram audio spikes in volume. Thats may happen because of system execution order where differrent systems changes underlying raylib sound object. This commits adds new system to control sound settings (volume, pan and pitch). style(formating): go fmt
chore(dev): adds more asserts on SpatialAudioSystem
…ssing docs(audio): clarify comment for Clip
style(audio-system): go fmt
thearturca
force-pushed
the
refactor/audio-system
branch
from
0079bdb to
1b6234b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds volume calculation for spatial audio and remove raylib sound mutation from SpatialAudioSystem to prevent audio glitching