Skip to content

Wrap database inserts in a transaction to speed up import. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rusty-dev wants to merge 1 commit into
base: schema-n-seeds
Choose a base branch
from
Open

Wrap database inserts in a transaction to speed up import. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/Phinx/Migration/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ public function dumpSchema($environment, $outfile=false)
$seeds = $config->getSeeds($adapter);
$seed_table_names = array_map(function ($s) {return $s->getName();}, $seeds);


$args = array_map(function ($list) { $c=count($list); $s=$c==1?'':'s'; return array($c, $s); }, array($tables, $seeds));
$output->writeln(
sprintf("Schema dump includes %d table%s (%d seed table%s)",
Expand All @@ -567,12 +567,12 @@ public function dumpSchema($environment, $outfile=false)
$foreign_keys[] = $fk;
if (preg_match('/REFERENCES [`"\']?(\w+)\b/i', $fk, $m)) {
# this $table depends on the reference table to be inserted into first
# set the seed table dependency
# set the seed table dependency
#
# only do this if not a self-circular dependency
if ($table->getName()!=$m[1]) {

// if both the table and the foreign key table are in the seed
// if both the table and the foreign key table are in the seed
// list, set the dependency, otherwise we're wasting time
if (static::listContainsAll($seed_table_names, $table->getName(), $m[1])) {
$ret = static::getSeed($table->getName(), $seeds)
Expand All @@ -592,11 +592,13 @@ public function dumpSchema($environment, $outfile=false)
fwrite($f, "\n");
}

// start a new transaction to speed up inserts
fwrite($f, "START TRANSACTION;\n");

$processed = array();

// this will have an infinite loop if we have circular dependency.
// A -> B -> C -> A, or A->A. These are explicitly detected before hand and
// A -> B -> C -> A, or A->A. These are explicitly detected before hand and
// removed. so we *shouldn't* loop forever. just in case, we'll count
$n = 0;
while (count($processed) != count($seeds)) {
Expand Down Expand Up @@ -631,6 +633,8 @@ public function dumpSchema($environment, $outfile=false)
}
}
}
// commit all the inserts in the end
fwrite($f, "COMMIT;\n");
}

private static function getSeed($name, &$seeds)
Expand Down