Open
Conversation
PauPauRob
reviewed
Oct 31, 2023
| @@ -0,0 +1,44 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
File should be capital Clock.js as this is a component. Components always capitalized
| this.timeZone = props.timeZone; | ||
| // Initialise component state to contain "date" attribute with current date and time | ||
| this.state = { date: new Date() }; | ||
| console.log(props.timeZone); |
There was a problem hiding this comment.
Let's always remove console logs before pushing our code, as those are just for debugging
| // Save setInterval timer ID in class variable for teardown in another class method | ||
| function updateDate() { | ||
| this.setState({date: new Date()}) | ||
| console.log("hi") |
Comment on lines
+4
to
+6
| constructor(props) { | ||
| super(props); | ||
| this.timeZone = props.timeZone; |
There was a problem hiding this comment.
this here is unnecessary. You should just be able to use this.props to access the props from anywhere in the component without defining those in the constructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i had a hard time trying to create the grid, eventually gave up🤦♀️. so i did the UTC instead.