Amelia | PTBC2-2 #28
Open
Amelia | PTBC2-2 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam9408
reviewed
Dec 21, 2021
| const imgContainer = document.createElement("div"); | ||
| imgContainer.classList.add("image-container"); | ||
| document.body.appendChild(imgContainer); | ||
| const goStart = document.createElement("img"); |
There was a problem hiding this comment.
Can improve readability by separating each of the const declarations with an empty line
liam9408
reviewed
Dec 21, 2021
| let splitWatch; | ||
|
|
||
| // stopwatch time display | ||
| const renderTime = (element, elapsed) => { |
liam9408
reviewed
Dec 21, 2021
| goStart.classList.add("img", "start"); | ||
| goStart.src = "/assets/play.png"; | ||
| imgContainer.appendChild(goStart); | ||
| const goStop = document.createElement("img"); |
There was a problem hiding this comment.
I think you can simply name these variables as startTimer, stopTimer, or even startButton, stopButton ... etc. This is to provide super clear context of what each button does.
liam9408
reviewed
Dec 21, 2021
|
|
||
| //concat all the units above | ||
| let text = ""; | ||
| text += hours.toString().padStart(2, "0") + " : "; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment? long. about 2 days
Please fill in one error and/or error message you received while working on this assignment.
Something is not a function
What part of the assignment did you spend the most time on?
Split and renderTime
Comfort Level (1-5): 3
Completeness Level (1-5): 4.5
What did you think of this deliverable? Split function is very tricky. I think its a good practice to use Date.now() for timer as opposed to normal increment
Is there anything in this code that you feel pleased about? Date.now() and renderTime