POCE.4: Timer - PTBC1 (Jia Yi) #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelle-mok
left a comment
michelle-mok
left a comment
There was a problem hiding this comment.
good work using setTimeout and setInterval!
consider adding more comments so that it is easier for the reader to follow your code
| stopwatchTime.innerHTML = `${displayHMS(milliSecs)}`; | ||
| if (isStopPressed) { | ||
| clearInterval(stopwatchCount); | ||
| milliSecs -= 1000; |
There was a problem hiding this comment.
what does this line do? will your code still work without it?
| stopwatchReset.classList.add("stopwatchButton"); | ||
| stopwatchReset.addEventListener("click", () => { | ||
| milliSecs = 0; | ||
| isStopPressed = true; |
There was a problem hiding this comment.
isStopPressed needs to be true here for the stopwatch to start again
| stopwatchReset.addEventListener("click", () => { | ||
| milliSecs = 0; | ||
| isStopPressed = true; | ||
| runStopWatch(); |
There was a problem hiding this comment.
consider not running runStopWatch() here, instead, reset the timer display like this :
stopwatchTime.innerHTML = "00:00:00";
also consider adding a canClick variable so that the reset button cannot be clicked unless the stop button has already been clicked:
let canClick = false;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment? 5
Please fill in one error and/or error message you received while working on this assignment.
Still cannot fix bug of reset button shifting after clicking.
What part of the assignment did you spend the most time on?
stopwatch feature
Comfort Level (1-5): 3
Completeness Level (1-5): 3
What did you think of this deliverable? good recap of concepts
Is there anything in this code that you feel pleased about? -