PTBC-1 zaver tan feng timer bootcamp #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanfeng95
changed the title
michelle-mok
reviewed
Sep 6, 2021
michelle-mok
left a comment
michelle-mok
left a comment
There was a problem hiding this comment.
code is well organised and nice work on using setInterval!
consider adding comments so that it is easier for the reader to follow your code
Comment on lines
+17
to
+54
| <div class="container"> | ||
| <div class="row"> | ||
| <div class="col-3"> | ||
| <div class = 'row align-text-center'> | ||
| <h5>Lap data</h5> | ||
| </div> | ||
| <div class = 'row align-text-center'> | ||
| <div id = 'lap_data' class = 'text-center'> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| <div class="col"> | ||
| <div class="row text-center"> | ||
| <h5>Elapsed time</h3> | ||
| </div> | ||
| <div class="row align-text-center" > | ||
| <div id ='Elapsed_time' class="text-center"> | ||
| <label id="minutes">00</label> | ||
| <label id="colon">:</label> | ||
| <label id="seconds">00</label> | ||
| </div> | ||
| </div> | ||
| <div class="row"> | ||
| <div class='col text-center'> | ||
| <button class="btn btn-primary" onClick='start()'>start</button> | ||
| </div> | ||
| <div class='col text-center'> | ||
| <button class="btn btn-danger" onclick='stop()'>stop</button> | ||
| </div> | ||
| </div> | ||
| <div class="row"> | ||
| <div class='col text-center'> | ||
| <button class="btn btn-primary" onclick = 'reset()'>reset</button> | ||
| </div> | ||
| <div class='col text-center'> | ||
| <button class="btn btn-primary" onclick='lap()'>lap </button> | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
all these should be created in script js using DOM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment?
2
Please fill in one error and/or error message you received while working on this assignment.
reset error -> lap did not reset properly
What part of the assignment did you spend the most time on?
lap of time
Comfort Level (1-5):
4
Completeness Level (1-5):
4
What did you think of this deliverable?
it was okay
Is there anything in this code that you feel pleased about?