PTBC1 - Kimmi Lee #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michelle-mok
reviewed
Sep 6, 2021
michelle-mok
left a comment
michelle-mok
left a comment
There was a problem hiding this comment.
nice work organising your code into functions!
what is the purpose of the onClick(event.currentTarget) for all the buttons?
keep up the good work!
| } | ||
| }, 100); | ||
| } | ||
| }; |
There was a problem hiding this comment.
nice work changing button colour on click!
| startButton.classList.add('stopwatch-button'); | ||
| startButton.innerText = 'Start'; | ||
| startButton.addEventListener('click', (event) => { | ||
| onClick(event.currentTarget); |
There was a problem hiding this comment.
what does the onClick do? would your code work without it?
Author
There was a problem hiding this comment.
the onClick is just to change the colour of the button for 200ms to know that i've clicked on it!
michelle-mok
reviewed
Sep 6, 2021
| stopButton.classList.add('stopwatch-button'); | ||
| stopButton.innerText = 'Stop'; | ||
| stopButton.addEventListener('click', (event) => { modeStop = true; | ||
| onClick(event.currentTarget); }); |
There was a problem hiding this comment.
this would be clearer if written like this :
stopButton.addEventListener('click', (event) => {
modeStop = true;
onClick(event.currentTarget);
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the survey before submitting the pull request. Thanks!
🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀
How many hours did you spend on this assignment? 1 (base)
Please fill in one error and/or error message you received while working on this assignment.
Empty argument for addEventListener
What part of the assignment did you spend the most time on?
reset button
Comfort Level (1-5): 3
Completeness Level (1-5): 3
What did you think of this deliverable?
Is there anything in this code that you feel pleased about?