feat(shared): valita methods for working directly with AbstractTypes#2899
Merged
darkgnotic merged 4 commits intomainfrom Nov 1, 2024
Merged
feat(shared): valita methods for working directly with AbstractTypes#2899darkgnotic merged 4 commits intomainfrom
darkgnotic merged 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
darkgnotic
commented
Nov 1, 2024
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| const AbstractType = Object.getPrototypeOf( |
Contributor
Author
There was a problem hiding this comment.
I could also export this directly (and remove the instanceOfAbstractType() method) if you think that's better.
lmk.
Contributor
There was a problem hiding this comment.
Maybe export a isAbstractType(v: unknown): v is AbstractType since that is what we actually want to test.
We could maybe even upstream something like that.
arv
reviewed
Nov 4, 2024
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| const AbstractType = Object.getPrototypeOf( |
Contributor
There was a problem hiding this comment.
Maybe export a isAbstractType(v: unknown): v is AbstractType since that is what we actually want to test.
We could maybe even upstream something like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i.e.
OptionalThis will facilitate more esoteric valita usage such as #2894