Girls gen updates #189
Girls gen updates #189
Conversation
markpete
left a comment
markpete
left a comment
There was a problem hiding this comment.
Let's see if we can get rid of the redundant code and make this more maintainable.
This comment was marked as resolved.
This comment was marked as resolved.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring of the auto-alignment and scoring logic, notably by adding AllianceUtils, ScoringType, and AlignType to improve code structure and reduce duplication. The Shuffleboard layout in elastic-layout.json has also been completely reorganized. My review focuses on improving performance by avoiding repeated object creation in AutoAlign, enhancing maintainability by removing magic numbers, and fixing a potential regression in the controller rumble feedback for scoring alignment. I also suggest a small improvement to the new AllianceUtils class to follow best practices.
Jetblackdragon
dismissed stale reviews from markpete, jamesdooley4, and koolpoolo
via
d5a696b
avoids calling isConnected 3 different times.
No description provided.