fix: Add MCP server logging and check execution success before completion #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Fixes #33 Changes: - Add MCP server configuration logging to AgentSDKExecutor for debugging - Check result.success before marking tasks complete in SugarLoop - Default success to False (fail-safe) if field is missing - Log warning when success field is missing from result - Tasks with success=False now properly marked as failed - Add MCP server config example to template config - Add comprehensive integration test suite (13 tests): - MCP server logging verification - Success/failure flow handling - Missing success field detection - End-to-end execution tests
cdnsteve
force-pushed
the
bugfix/33-mcp-server-passthrough
branch
from
9989ea7 to
bed4e13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #33
result.successbefore marking tasks complete in SugarLoopFalse(fail-safe) if field is missingsuccess=Falsenow properly marked as failedRoot Cause Analysis
The issue reported that tasks were being marked complete prematurely. Investigation found:
sugar.claude.mcp_servers→AgentSDKExecutor→SugarAgent→ClaudeAgentOptionsis correctcomplete_work()was called unconditionally without checking execution resultTest plan
successfield correctlyNote
This is a partial fix. It adds observability and safety, but the root cause (agent creates files but doesn't execute tests) also requires users to: