fix: Add timeout wrapper to async query generator #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The async for loop over query() had no timeout, causing tasks to hang indefinitely when the Claude Agent SDK generator didn't signal completion even though work was done (files created but never committed). Changes: - Wrap async for loop with asyncio.timeout() in _execute_with_streaming() - Increase default timeout from 300s to 7200s (2 hours) for long tasks - Add TimeoutError handling to return partial results gracefully - Add test for timeout behavior Fixes hung tasks in Sugar autonomous execution where generators never terminated after Claude finished using tools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.timeout()in_execute_with_streaming()to prevent indefinite hangsProblem
Tasks were hanging indefinitely when the Claude Agent SDK generator didn't signal completion even though work was done. Files would be created but commits never happened because the generator loop never terminated.
Test plan
test_execute_with_timeouttest verifies timeout behavior