Fix PHP 8.3 compatibility issues and WordPress 6.7 textdomain loading #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some errors showing after PHP 8.3 that gave "html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated" errors and caused issues with the button sizes being too large in the Customize admin overlay. These should fix them.
Should also help fix the error "PHP Notice: Function _load_textdomain_just_in_time was called incorrectly. Translation loading for the scriptless-social-sharing domain was triggered too early." experienced by another user.
Needs testing, might need a few more tweaks too. None of the versioning was updated.