Tap at point#2
Open
ehealthinnovation wants to merge 2 commits intorobholland:masterfrom
ehealthinnovation:TapAtPoint
Open
Tap at point#2ehealthinnovation wants to merge 2 commits intorobholland:masterfrom ehealthinnovation:TapAtPoint
ehealthinnovation wants to merge 2 commits intorobholland:masterfrom
ehealthinnovation:TapAtPoint
Conversation
|
Won't coordinates be confused by different resolutions, thereby hard-coding the step definition to a particular resolution or device? Is there a reason you can't add an accessibility label to the custom element being tapped so that iCuke can find it without hard-coding coordinates? |
|
Also, would you be willing to resubmit against BlueFrogGaming/icuke with a cucumber feature test? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As much as it's nice to build a nice domain specific DSL for your stories, for various reasons sometimes you have to give up the syntactic sugar and just "tap" at an x,y coordinate. This patch enables that.