set certificate type based on CSRs corda-role#14
Open
berndos wants to merge 1 commit intoroastario:masterfrom
Open
set certificate type based on CSRs corda-role#14berndos wants to merge 1 commit intoroastario:masterfrom
berndos wants to merge 1 commit intoroastario:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current implementation it is not possible to obtain notary-certificates from the doorman as of Corda 4.8 (or earlier?): Corda now expects an
net.corda.core.CordaOID.X509_EXTENSION_CORDA_ROLEextension with valuenet.corda.core.internal.CertRole.SERVICE_IDENTITY, but in the current implementation, the value is hardcoded tonet.corda.core.internal.CertRole.NODE_CA. This PR attempts to fix this by setting the extension-value depending on the requested role in the CSR.