forked from nomns/nparse
-
Notifications
You must be signed in to change notification settings - Fork 3
Dlvax #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ewjax
wants to merge
22
commits into
rm-you:share_loc_websocket
Choose a base branch
from
ewjax:dlvax
base: share_loc_websocket
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dlvax #2
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e11dd09
Merge pull request #36 from rm-you/share_loc_websocket
rm-you 970110b
dlvax commit
ewjax 807cb50
small edits
ewjax 77ecb8f
cleaned up Parser inheritance
ewjax 223b14e
small edit
ewjax fa4fa89
editorial
ewjax e84d05a
addressing some PEP warnings
ewjax 7d31933
PR comments.
ewjax 25490a1
PR comments:
ewjax 8258728
added 'slice' to melee regexp
ewjax 9cd0cc0
Fix two discord color warnings
rm-you fbaf789
Fix AA_EnableHighDpiScaling error
rm-you cb21854
Fix exit if logdir unconfigured
rm-you 46a4a2a
Close splash screen if one is open (pyInstaller)
rm-you 518c436
Stop using custom qt.conf runtime hook
rm-you d210839
Clean up specfile, add splash!
rm-you 083c27b
Be threadsafe for location service RUN flag
rm-you 23c9a5c
Bump version to 0.6.5
rm-you 4eca238
Merge pull request #45 from rm-you/add_splash
rm-you dcbe69a
Update README for new pyInstaller info
rm-you d12a058
Merge remote-tracking branch 'upstream/master' into dlvax
ewjax c046203
updated coordinates of bank in Crystal caverns
ewjax File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on the fence about this, but it's growing on me. Maybe there would be other things that don't need a window? IDK, still thinking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does solve the problem neatly for any non-window parser, now or in the future.