Skip to content

don't delete the handler in loseConnection #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wulczer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't delete the handler in loseConnection #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test_websocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,3 +500,14 @@ def test_connectionLost(self):
"""
self.request.connectionLost(Failure(CONNECTION_DONE))
self.handler.lostReason.trap(ConnectionDone)

def test_loseConnection_and_connectionLost(self):
"""
L{Request.connectionLost} called after
L{WebSocketTransport.loseConnection} does not cause problems.
"""
self.handler.transport.loseConnection()
# loseConnection() on the transport will disconnect the request, and it
# will get its connectionLost method fired
self.request.connectionLost(Failure(CONNECTION_DONE))
self.assertTrue(self.channel.transport.disconnected)
3 changes: 0 additions & 3 deletions websocket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,6 @@ def loseConnection(self):
Close the connection.
"""
self._request.transport.loseConnection()
del self._request.transport
del self._request
del self._handler

class WebSocketHandler(object):
"""
Expand Down