new class WebSocketFactory (WebSocket Wrapper)#16
Open
iuridiniz wants to merge 3 commits intorlotun:masterfrom
Open
new class WebSocketFactory (WebSocket Wrapper)#16iuridiniz wants to merge 3 commits intorlotun:masterfrom
iuridiniz wants to merge 3 commits intorlotun:masterfrom
Conversation
Factory which wraps another factory to provide WebSockets transports for all of its protocols.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The websocket implementation as a standalone wrapper for Twisted protocols (available at http://paste.pocoo.org/show/451569/ ) allows us to make a twisted protocols available over websocket
I wrote a new class in order to provide this behaviour too and I submitted in theses commits
3cf7b7c → class implementation
9b32bcf → example of use
I don't know how to write tests for it, so, sorry, there are no tests for this newer class.