forked from JanKallman/EPPlus
-
Notifications
You must be signed in to change notification settings - Fork 10
Fix tests and add GitHub Action workflows #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shane32
wants to merge
28
commits into
rimland:master
Choose a base branch
from
Shane32:fix_tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the tests so the run correctly on Linux and Windows. It also includes GitHub Action workflows to run tests during pull requests to test the code and documentation on the following platforms:
All but one of the tests works properly. The one test that fails is the
CrossSheetInsertRowsUpdatesReferencesCorrectlytest withinWorkSheetTests.cs. It fails only when running on Linux; it works correctly across all platforms on Windows. This is probably a bug that needs fixing. Note that many of the existing tests required a xlsx file to test against, which are not included in this repository, and as such were previously disabled. I did not touch these tests; they are still disabled.There is also a GitHub Action included to build the EPPlusFree package (nupkg file) and all documentation upon pushing to master (either directly, or indirectly via a merged pull request). The nupkg and docs are uploaded as artifacts to the workflow. In addition, NuGet package is uploaded to the GitHub Package Repository as a beta version.
I can also write a GitHub Action script to publish the nupkg file to NuGet.org upon issuing a release, using the version number associated with the release. The nupkg and docs can be automatically attached to the release as release artifacts. As such, releasing a new version to NuGet.org requires only a couple clicks from the GitHub website by a collaborator. Please let me know if you are interested; otherwise I will just publish my own fork to NuGet.
Note that this PR includes and requires the two prior PRs: