Fix cellular data start #261
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not detach when ordered to do so, because for some broken rils we cannot re-attach again (fp2). This is safe as anyway we are not doing this in old rils.
alfonsosanchezbeato
added a commit
to alfonsosanchezbeato/device-files
that referenced
this pull request
Jan 13, 2017
There is a bug in the ril that prevent us from re-attaching after we have explcitly detached. As a workaround, never detach explicitly. Based on rilmodem/ofono#261 .
Contributor
|
It seems a bit heavy handed to just stop sending RIL_REQUEST_ALLOW_DATA requests when attached==0 in order to fix a semi-broken rild. Are you sure there are no potential side-effects? Couldn't we quirk the specific device? |
Contributor
Author
|
@tonyespy actually I agree with you. I do not see side effects in other devices, like Pro 5, however I will eventually resubmit this as a quirk. Anyway I will keep this PR around for the moment. as it was used to create a binary for the ubports fp2 overlay. Please do not merge ;) |
Contributor
|
@alfonsosanchezbeato OK, thanks for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cellular data on start for fp2