This repository was archived by the owner on Jan 27, 2025. It is now read-only.
Group 5 - Case Study 3 #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor: Modified data,fcc and size as static final variables
issue#3: Mutable fields should not be "public static"
Refactor: anonymous inner class to lambda expression - Issue #5
Refactored "public static WHEEL_AMP" field to final - Issue#10
…e always implicitly imported
Refactor: Removed unnecessary imports
…or of MjpegFileWriter and finishAVI method
Refactored Software Clone in CursorLoader.java - Issue#70
issue#73 : Software Clone for Duplicate Code in MjpegFileWriter at MjpegFileWriter and finishAVI method.
Merge with Rilling-Master
…extractAndFlipData - Issue#81
Refactored Software Clone in AWTLoader.java - Issue#81
refactored AWTLoader.java at line 114 and 119 Remove Duplicate Logic for RGBA Pixel Processing rilling#86
Removed the clones existing at lines 306 and 526 in MjpegFileWriter.java
…2024 into caseStudy2Version2
Case Study Version 2
Software Vulnerability Fix - Added Logger at jme3-desktop/AppletHarness.java - Issue#117
… object to free system resources - Issue#122
Software Vulnerability Fix - Changed the cleanup() to properly shut down ExecutorService in VideoRecorderAppState.java - Issue#119
Software Vulnerability Fix - Added a call dispose() on createGraphics object to successfully release resource after use - Issue#122
remove vulnerability by replaced printStackTrace with Proper Logging in AppletHarness.java
…n catch block for InterruptedException
Preserve thread interruption status by setting the interrupted flag in catch block for InterruptedException
Conflicts resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to merge all the changes made by Group 5 for Case Study 3.
Resolved issues
#117 - Active Debug Code at jme3-desktop/AppletHarness.java
#119 - VideoRecorderAppState.java missing ExecutorService Shutdown
#122 - MjpegFileWriter.java :Missing a call to dispose() on createGraphics object to release resource after use
#157 - Remove Software Vulnerability: Replaced printStackTrace with Proper Logging in AppletHarness.java
#169 - catchingInterruptedExceptionWithoutInterrupt in VideoRecorderAppState.java(line 260)