This repository was archived by the owner on Jan 27, 2025. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 18
Changes from Group 1 - Case Study 2 & 3 #107
Open
hanif-ali
wants to merge
38
commits into
rilling:master
Choose a base branch
from
hanif-ali:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4 The unused variable 'isTouch' and the commented code which referred to it were removed from the 'onKey' method.
Issue #4 - Removing Unused Variable in AndroidInputHandler.java
#9 Remove commented code from AndroidGestureProcessor.java
Issue#1 Removed Commented Out Lines in MjpegFileWriter.java
…-code Issue-46 Updated MjpegFileWriter.java and removed commented-out-line
…ndroidLocator.java-(lines-109-&-128)
…cation-in-AndroidLocator.java-(lines-109-&-128) Eliminated a code duplication in AndroidLocator.java
remove duplicated code and added a helper method
Issue #28 Remove code duplication in GlfwKeymap.java
Checkstyle library version updated from 9.3 to 10.20.1
fix: Make sure the use of WRITE_EXTERNAL_STORAGE permission is necess…
Collaborator
Author
|
@rilling The PR is mergeable but we received a feedback in CS2 that it is not. Could you please check? |
Fix MALICIOUS_CODE vulnerability identified by SpotBugs (Case study 3)
Update XMLImporter.java
…ated-before-production Issue#155-fixed Insecure Configuration vulnerability
Fixes rilling#116 - Checkstyle library version update
Collaborator
Author
|
Since this PR is created from the master branch, it also has commits for CS3 now as they have been merged into the fork's master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case Study 2 Fixes:
Case Study 3 Fixes: