Skip to content
This repository was archived by the owner on Jan 27, 2025. It is now read-only.

Conversation

AminAmani83 and others added 23 commits October 5, 2024 18:25
Fixes #4 
The unused variable 'isTouch' and the commented code which referred to it were removed from the 'onKey' method.
Issue #4 - Removing Unused Variable in AndroidInputHandler.java
…pe to static final. (#6)

* fixed issue #2 by Changing final field to static final.

* fixed issue #3 by Renaming ESCAPE_EVENT to ESCAPEEVENT.
#9 Remove commented code from AndroidGestureProcessor.java
Issue#1 Removed Commented Out Lines in MjpegFileWriter.java
…-code

Issue-46 Updated MjpegFileWriter.java and removed commented-out-line
The duplicate code has been extracted as a private static method.

Co-authored-by: aminamani83 <aminamani83@gmail.com>
…cation-in-AndroidLocator.java-(lines-109-&-128)

Eliminated a code duplication in AndroidLocator.java
remove duplicated code and added a helper method
Issue #28 Remove code duplication in GlfwKeymap.java
@hanif-ali hanif-ali changed the title Sync fork with main repo Changes from Group 1 - Code Duplication Nov 13, 2024
@hanif-ali
Copy link
Collaborator Author

hanif-ali commented Dec 3, 2024

@rilling The PR is mergeable but we received a feedback in CS2 that it is not. Could you please check?

Fix MALICIOUS_CODE vulnerability identified by SpotBugs (Case study 3)
…ated-before-production

Issue#155-fixed Insecure Configuration vulnerability
@hanif-ali
Copy link
Collaborator Author

hanif-ali commented Dec 3, 2024

Since this PR is created from the master branch, it also has commits for CS3 now as they have been merged into the fork's master.

@hanif-ali hanif-ali changed the title Changes from Group 1 - Code Duplication Changes from Group 1 - Case Study 2 & 3 Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants