Fix iOS prebuild with Expo SDK 54+ (RCT-Folly / RCT_USE_RN_DEP)#121
Open
samuelbeaulieu wants to merge 1 commit intoricohapi:mainfrom
Open
Fix iOS prebuild with Expo SDK 54+ (RCT-Folly / RCT_USE_RN_DEP)#121samuelbeaulieu wants to merge 1 commit intoricohapi:mainfrom
samuelbeaulieu wants to merge 1 commit intoricohapi:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running expo prebuild on Expo SDK 54+, pod install fails because theta-client-react-native declares a direct dependency on
RCT-Folly, which is no longer resolved that way in the new setup.Error
Cause
In Expo SDK 54+, React Native sets
RCT_USE_RN_DEP=1and supplies Folly (and related New Architecture deps) itself. This podspec always addsRCT-Follyand sets-DRCT_NEW_ARCH_ENABLED=1whenRCT_NEW_ARCH_ENABLED=1, which conflicts with that and leads to the “Unable to find a specification forRCT-Folly” error.Fix
Only add the
RCT-Follydependency and the New Architecture compiler flags whenRCT_USE_RN_DEP != '1'. WhenRCT_USE_RN_DEP=1(Expo SDK 54+), rely on React Native’s Folly and flags. For the case where we do depend on Folly, pinRCT-Follytofolly_versionto avoid version mismatches.Testing
Verified
expo prebuild --cleanandpod installsucceed in an Expo SDK 54 project using the patch.