Focus Target/Buff Bar support #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the build warnings for other OS
I might have accidentally spent a few hours on this. The pre-existing compiler warnings are still there and yours to solve how you see fit. Resolves rgd87#4 on merge.
fixed warnings, solved the focus target issue using a disgusting hack - check the text color for white (this seems to still be valid for buffs/debuffs without durations)
Technically uses more CPU cycles but the target logic seems to update on a very slightly differently timed loop than the UI, causing weird issues
Some annoyances because the ResNode doesn't have a ChildCount
Author
|
Hm, this currently ignores if the order of debuffs is re-sorted on your buff bar such as justify-right |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for scaling on the focus target, and on your own buff/debuff bars (merged or separate). Since I wasn't originally planning to make drastic changes or submit a PR, I had formatted it to my own style - you may wish to run an autoformat before merging, but unfortunately either way the
blamewill be a little wonky.Feedback is appreciated.