Allow queueing of callbacks in destructors #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

danog wants to merge 5 commits into revoltphp:main from danog:fix_destruct

Closed

Allow queueing of callbacks in destructors #99

Fixes

Annotations

13 warnings

Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use the latest version of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-09-16-notice-of-upcoming-deprecations-and-changes-in-github-actions-services/

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

examples/benchmark-memory.php#L24

examples/benchmark-memory.php:24:21: MixedMethodCall: Cannot call constructor on an unknown class (see https://psalm.dev/015)

examples/benchmark-ticks-delay.php#L13

examples/benchmark-ticks-delay.php:13:26: MixedArgumentTypeCoercion: Argument 1 of Revolt\EventLoop::defer expects Closure(string):void, but parent type Closure provided (see https://psalm.dev/194)

examples/benchmark-timers-delay.php#L13

examples/benchmark-timers-delay.php:13:29: MixedArgumentTypeCoercion: Argument 2 of Revolt\EventLoop::delay expects Closure(string):void, but parent type Closure provided (see https://psalm.dev/194)

src/EventLoop/Driver/EvDriver.php#L168

src/EventLoop/Driver/EvDriver.php:168:32: MixedAssignment: Unable to determine the type that $callback is being assigned to (see https://psalm.dev/032)

src/EventLoop/Driver/EvDriver.php#L169

src/EventLoop/Driver/EvDriver.php:169:24: MixedArrayOffset: Cannot access value on variable $this->events using mixed offset (see https://psalm.dev/031)

src/EventLoop/Driver/EvDriver.php#L169

src/EventLoop/Driver/EvDriver.php:169:38: MixedAssignment: Unable to determine the type that $id is being assigned to (see https://psalm.dev/032)

src/EventLoop/Driver/EvDriver.php#L169

src/EventLoop/Driver/EvDriver.php:169:44: MixedPropertyFetch: Cannot fetch property on mixed var $callback (see https://psalm.dev/034)

src/EventLoop/Driver/EvDriver.php#L173

src/EventLoop/Driver/EvDriver.php:173:21: MixedArrayOffset: Cannot access value on variable $this->events[$id] using mixed offset (see https://psalm.dev/031)

src/EventLoop/Driver/EvDriver.php#L173

src/EventLoop/Driver/EvDriver.php:173:21: MixedPropertyTypeCoercion: $this->events expects 'array<string, EvWatcher>', parent type `non-empty-array<array-key, EvWatcher>` provided (see https://psalm.dev/196)

src/EventLoop/Driver/EvDriver.php#L177

src/EventLoop/Driver/EvDriver.php:177:21: MixedArrayOffset: Cannot access value on variable $this->events[$id] using mixed offset (see https://psalm.dev/031)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow queueing of callbacks in destructors #99

Uh oh!

Uh oh!

Allow queueing of callbacks in destructors #99

Uh oh!

Annotations

The logs for this run have expired and are no longer available.

Re-running jobs...