Updated requirements.txt#244
Open
Sam071100 wants to merge 2 commits intorevault:masterfrom
Sam071100:master
Open
Updated requirements.txt#244Sam071100 wants to merge 2 commits intorevault:masterfrom Sam071100:master
Sam071100 wants to merge 2 commits intorevault:masterfrom
Sam071100:master
Conversation
darosior
reviewed
Jul 26, 2021
Member
darosior
left a comment
darosior
left a comment
There was a problem hiding this comment.
Cool that you added the instructions for Windows! However i think it would be more appropriate to add them once we are able to actually run the testsuite under Windows?
Side nit (nit means you do not need to apply the change): it's really helpful to have detailed commit messages. But keep in mind to have a short subject line, followed by a blank line and finally the body of the message.
Sam071100
changed the title
Member
|
utACK ee0f942 |
Member
|
Can you remove the merge commit? I'll merge it afterward. |
Member
|
Ping @Sam071100 |
Member
|
Needs rebase @Sam071100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the version of psycopg2 from 2.8 to 2.9 for Windows compatibility in test/requirements.txt