Skip to content

Conversation

@RhysB
Copy link
Member

@RhysB RhysB commented Dec 30, 2023

No description provided.

@RhysB RhysB added enhancement New feature or request help wanted Extra attention is needed Low Priority labels Dec 30, 2023
@RhysB RhysB self-assigned this Dec 30, 2023
@RhysB
Copy link
Member Author

RhysB commented Dec 30, 2023

@moderatorman @Moresteck Opinions on this feature or change?

Obviously, it is still in prototype, just wondering if anyone had any major objections.

@notdevcody
Copy link
Contributor

What actual benefits does this provide?

@moderatorman
Copy link
Contributor

I don't even know what you're talking about. What did you do?

@Moresteck
Copy link
Collaborator

Testing it on Betacraft server, runs fine so far. Converted 3248 cache entries in 15 seconds.

I think using SQLite for the UUID cache is cleaner (and possibly faster?) than using a json.

I'll update you if the current implementation misbehaves.

@Moresteck
Copy link
Collaborator

I've noticed that username_lower is never actually set in the DB.
Thus, the methods that rely on it always return null values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed Low Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants