Implement elimPropInv for profunctor optics extraction#51
Draft
Copilot wants to merge 3 commits intorowtypes-with-halflenses-and-halfprismsfrom
Draft
Implement elimPropInv for profunctor optics extraction#51Copilot wants to merge 3 commits intorowtypes-with-halflenses-and-halfprismsfrom
Copilot wants to merge 3 commits intorowtypes-with-halflenses-and-halfprismsfrom
Conversation
Co-authored-by: erykciepiela <5385827+erykciepiela@users.noreply.github.com>
Co-authored-by: erykciepiela <5385827+erykciepiela@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Work on TODO in ElimPropP module
Implement elimPropInv for profunctor optics extraction
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
elimPropInvfunction was stubbed withunsafeThrow "TODO". This function extracts the elimination functions -> Tuple t ofrom a profunctor optic encoding.Implementation
Dual-instance approach to extract both components:
t: Use function instancef (const unit) swhich applies the(->)instance that preserves the eliminated structureo: Use Cont instance withunwrap (f (Cont \_ -> identity)) (unsafeCoerce unit :: t -> o) sLimitation
The Cont instance's
liftElimPropignores its input and discards theocomponent fromTuple s o, making extraction withoutunsafeCoerceimpossible with the current encoding. This mirrors similar limitations ineditPropInv(also TODO).Original prompt
Created from VS Code via the GitHub Pull Request extension.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.