-
Notifications
You must be signed in to change notification settings - Fork 42
Update dev dependencies, Nodejs 20 (lts) support #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Artem Kozlov <artem@rem.sh>
update webpack, typescript and sass Signed-off-by: Artem Kozlov <artem@rem.sh>
e46af16 to
8f4110b
Compare
|
@dianat Potentially there can be some subtle issues because new node resolves dependencies slightly differently. |
Signed-off-by: Artem Kozlov <artem@rem.sh>
Hi Artem, Please see attached. Thank you!
|
Signed-off-by: Artem Kozlov <artem@rem.sh>
|
Hi @dianat. Thank you for looking into the PR. I fixed the issue with styles. But I can't reproduce the issue with forms, I tried with clean checkout and everything seems to be working. |
|
@dianat try to remove node_modules folder before starting the system, latest node is using slightly different dependencies resolution |
|
I've just tried it with the changes and it's looking fine now. I had some test custom-app in my runtime-data. We will do a bit more testing, but this is great! |
Adjust check to include all resources in /assets folder, not only images. Signed-off-by: Artem Kozlov <artem@rem.sh>
|
@dianat thanks for merging! 🎉 |
|
@aindlq There's a problem in the css used in the header and I think it's related to this PR. |




Why
Because currently recommended node 12 is not supported anymore.
What
We need to enable node js legacy mode because our dependencies are quite old. So this can be considered a quickfix. Proper fix would involve updating some dependencies, like React etc.
This PR depends on researchspace/YASGUI.YASR#1 . So you merge that one I would update package.json to point to the updated version. Right now it points to my fork.
Also this PR uses
sasspackage instead ofnode-sass. Which is also deprecated, requires python2 and for me it was not working reliably with the latest node.How To Test
Try to run the build with the latest node js LTS release.