Skip to content

Conversation

@aindlq
Copy link
Member

@aindlq aindlq commented Mar 20, 2024

Why

Because currently recommended node 12 is not supported anymore.

What

We need to enable node js legacy mode because our dependencies are quite old. So this can be considered a quickfix. Proper fix would involve updating some dependencies, like React etc.

This PR depends on researchspace/YASGUI.YASR#1 . So you merge that one I would update package.json to point to the updated version. Right now it points to my fork.

Also this PR uses sass package instead of node-sass. Which is also deprecated, requires python2 and for me it was not working reliably with the latest node.

How To Test

Try to run the build with the latest node js LTS release.

@aindlq aindlq requested a review from dianat March 20, 2024 13:03
@aindlq aindlq marked this pull request as draft March 20, 2024 13:04
aindlq added 2 commits April 21, 2024 11:34
Signed-off-by: Artem Kozlov <artem@rem.sh>
update webpack, typescript and sass

Signed-off-by: Artem Kozlov <artem@rem.sh>
@aindlq aindlq force-pushed the node-lts-support branch from e46af16 to 8f4110b Compare April 22, 2024 09:25
@aindlq aindlq changed the title Nodejs 20 (lts) support Update dev dependencies, Nodejs 20 (lts) support Apr 22, 2024
@aindlq aindlq marked this pull request as ready for review April 22, 2024 09:31
@aindlq
Copy link
Member Author

aindlq commented Apr 22, 2024

@dianat
I've updated all major dev dependencies like webpack, typescript and sass to the latest versions so now the whole thing can be used with the latest node without "hacks".

Potentially there can be some subtle issues because new node resolves dependencies slightly differently.

Signed-off-by: Artem Kozlov <artem@rem.sh>
@dianat
Copy link
Collaborator

dianat commented Apr 22, 2024

@dianat I've updated all major dev dependencies like webpack, typescript and sass to the latest versions so now the whole thing can be used with the latest node without "hacks".

Potentially there can be some subtle issues because new node resolves dependencies slightly differently.

Hi Artem,
I've just tried it and the big issues are see are when creating entities of any type and the Resource configuration section in the admin page. Maybe I missed something in what you wrote in terms of testing (I will checked out the PR):

Please see attached. Thank you!

Screenshot 2024-04-22 at 16 16 31 Screenshot 2024-04-22 at 16 15 47

Signed-off-by: Artem Kozlov <artem@rem.sh>
@aindlq
Copy link
Member Author

aindlq commented Apr 22, 2024

Hi @dianat. Thank you for looking into the PR. I fixed the issue with styles. But I can't reproduce the issue with forms, I tried with clean checkout and everything seems to be working.

@aindlq
Copy link
Member Author

aindlq commented Apr 22, 2024

@dianat try to remove node_modules folder before starting the system, latest node is using slightly different dependencies resolution

@dianat
Copy link
Collaborator

dianat commented Apr 22, 2024

I've just tried it with the changes and it's looking fine now. I had some test custom-app in my runtime-data. We will do a bit more testing, but this is great!

aindlq and others added 3 commits April 29, 2024 18:42
@dianat dianat merged commit 173ab08 into researchspace:rs-new-design May 7, 2024
@aindlq aindlq deleted the node-lts-support branch May 8, 2024 08:21
@aindlq
Copy link
Member Author

aindlq commented May 8, 2024

@dianat thanks for merging! 🎉

@giancrys84
Copy link
Member

@aindlq There's a problem in the css used in the header and I think it's related to this PR.
Screenshot 2024-05-08 at 19 30 18
In the example you can see the .form-control class has style from _table.scss and _forms.scss (from bootstrap-sass) but it's not using at all the style from the component in form.scss (image below)
Screenshot 2024-05-08 at 19 33 54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants