-
Notifications
You must be signed in to change notification settings - Fork 51
chore: add worktree setup scripts and AGENTS.md documentation #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add Conductor worktree scripts (setup-worktree.sh, cleanup-worktree.sh) - Add conductor.json config for Conductor integration - Add AGENTS.md documentation for poc-pos-app, W3MWagmi, rn_cli_wallet - Add CLAUDE.md files pointing to AGENTS.md for all projects - Consolidate copy-sample-files.sh scripts with existence checks - Replace setup-secrets.js with copy-sample-files.sh in pos-app and poc-pos-app - Add postinstall hooks to run copy-sample-files.sh automatically - Update environment variables documentation in all AGENTS.md files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude finished @ignaciosantise's task in 2m 11s —— View job Code ReviewFound 6 issue(s)Issue 1: Missing source file validation in copy_if_missing functionID: copy-sample-missing-validation-a7c1 copy_if_missing() {
local src="$1"
local dest="$2"
if [ ! -f "$src" ]; then
echo "Error: Source file not found: $src"
return 1
fi
if [ ! -f "$dest" ]; then
cp "$src" "$dest"
echo "Copied: $dest"
else
echo "Skipped (exists): $dest"
fi
}Issue 2: Missing source file validation in copy_if_missing functionID: copy-sample-missing-validation-b8d2 Issue 3: Missing source file validation in copy_if_missing functionID: copy-sample-missing-validation-c9e3 Issue 4: Missing source file validation in copy_if_missing functionID: copy-sample-missing-validation-d1f4 Issue 5: Hardcoded fallback path in setup-worktree.sh may not be portableID: setup-worktree-hardcoded-path-e2a5 SOURCE_DIR="${CONDUCTOR_ROOT_PATH:-$HOME/projects/react-native-examples}"
if [ ! -d "$SOURCE_DIR" ]; then
echo -e "${RED}Error: Source directory not found: $SOURCE_DIR${NC}"
echo "Please set CONDUCTOR_ROOT_PATH or run from correct location"
exit 1
fiIssue 6: Missing executable permissions on new copy-sample-files.sh scriptsID: copy-sample-no-exec-perms-f3b6 chmod +x dapps/poc-pos-app/scripts/copy-sample-files.sh
chmod +x dapps/pos-app/scripts/copy-sample-files.sh
git add dapps/poc-pos-app/scripts/copy-sample-files.sh dapps/pos-app/scripts/copy-sample-files.shAutomated Checks✅ No external domain URLs detected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Conductor worktree integration and consolidates project setup scripts across multiple React Native projects. It replaces Node.js-based setup scripts with unified shell scripts that check for file existence before copying, adds comprehensive AI agent documentation (AGENTS.md), and configures automatic setup via postinstall hooks.
Changes:
- Add Conductor worktree scripts (
setup-worktree.sh,cleanup-worktree.sh) andconductor.jsonconfiguration - Replace
setup-secrets.jswith unifiedcopy-sample-files.shscripts that skip existing files - Add
AGENTS.mddocumentation for all projects with architecture, tech stack, and development guidelines - Add
CLAUDE.mdfiles pointing toAGENTS.mdin each project - Configure postinstall hooks to automatically run setup scripts after package installation
Reviewed changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/setup-worktree.sh | Conductor workspace setup script that symlinks env files and runs project setup scripts |
| scripts/cleanup-worktree.sh | Cleanup script that removes node_modules and build artifacts for archiving |
| conductor.json | Conductor configuration linking to setup and cleanup scripts |
| wallets/rn_cli_wallet/scripts/copy-sample-files.sh | Unified copy script with existence checks (replaces old bash script) |
| wallets/rn_cli_wallet/package.json | Adds postinstall hook to run copy-sample-files.sh |
| wallets/rn_cli_wallet/CLAUDE.md | Points to AGENTS.md for AI agent guidance |
| wallets/rn_cli_wallet/AGENTS.md | Comprehensive documentation for RN CLI Wallet project |
| dapps/pos-app/scripts/copy-sample-files.sh | New unified copy script with existence checks |
| dapps/pos-app/package.json | Updates postinstall to use copy-sample-files.sh instead of setup-secrets.js |
| dapps/pos-app/AGENTS.md | Updates environment variables section and code quality guidelines |
| dapps/pos-app/scripts/setup-secrets.js | Removed in favor of copy-sample-files.sh |
| dapps/poc-pos-app/scripts/copy-sample-files.sh | New unified copy script with existence checks |
| dapps/poc-pos-app/package.json | Updates postinstall to use copy-sample-files.sh instead of setup-secrets.js |
| dapps/poc-pos-app/CLAUDE.md | Points to AGENTS.md for AI agent guidance |
| dapps/poc-pos-app/AGENTS.md | Comprehensive documentation for PoC POS App project |
| dapps/poc-pos-app/scripts/setup-secrets.js | Removed in favor of copy-sample-files.sh |
| dapps/W3MWagmi/scripts/copy-sample-files.sh | Unified copy script with existence checks (replaces old bash script) |
| dapps/W3MWagmi/package.json | Adds postinstall hook to run copy-sample-files.sh |
| dapps/W3MWagmi/CLAUDE.md | Points to AGENTS.md for AI agent guidance |
| dapps/W3MWagmi/AGENTS.md | Comprehensive documentation for W3MWagmi project |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Shell scripts don't work in Vercel's build environment. Changed pos-app and poc-pos-app to use Node.js version of copy-sample-files script. - Replace copy-sample-files.sh with copy-sample-files.js for Expo projects - Update setup-worktree.sh to handle both .js and .sh versions - Keep shell scripts for W3MWagmi and rn_cli_wallet (React Native CLI) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Skip gracefully when source files don't exist (e.g., in Vercel builds where secrets.properties.mock is not present). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Revert pos-app and poc-pos-app to use original setup-secrets.js to avoid Vercel build issues. Keep copy-sample-files.sh only for W3MWagmi and rn_cli_wallet which don't deploy to Vercel. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Address review feedback: check if source file exists before attempting to copy to avoid cp errors when mock files are missing. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
setup-worktree.sh,cleanup-worktree.sh) for easy workspace setup and cleanupconductor.jsonconfig for Conductor integrationAGENTS.mddocumentation forpoc-pos-app,W3MWagmi, andrn_cli_walletCLAUDE.mdfiles pointing toAGENTS.mdfor all projectscopy-sample-files.shscripts with existence checks (won't override existing files)setup-secrets.jswithcopy-sample-files.shinpos-appandpoc-pos-apppostinstallhooks to runcopy-sample-files.shautomaticallyAGENTS.mdfilesChanges
Worktree Scripts
scripts/setup-worktree.sh- Symlinks env files and sentry.properties from main repo, runs copy-sample-files scriptsscripts/cleanup-worktree.sh- Removes node_modules, android/build, ios/Pods, ios/build for archivingDocumentation
AGENTS.mdfiles for AI agents with project overview, tech stack, architecture, and code quality guidelinesCLAUDE.mdfiles that point toAGENTS.mdScript Improvements
copy-sample-files.shto check if files exist before copyingnpm/yarn installTest plan
setup-worktree.shin a new Conductor workspacecleanup-worktree.shremoves expected directoriespostinstallhooks run correctly afteryarn installcopy-sample-files.shskips existing files🤖 Generated with Claude Code