Skip to content

Conversation

@rtomas
Copy link
Contributor

@rtomas rtomas commented Jan 15, 2026

Description

  • Fix SVG empty width="" and height="" attribute errors when rendering Phosphor icons with size="inherit"
  • Use Lit's ifDefined directive to omit the size attribute when undefined instead of rendering empty strings

Test plan

  • Open a page with AppKit wallet connect modal
  • Click on wallet connectors (MetaMask, WalletConnect, etc.)
  • Open browser DevTools Console
  • Verify no SVG attribute errors appear ( attribute width: Unexpected end of attribute)

🤖 Generated with https://claude.com/claude-code

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Associated Issues

For Linear issues: Closes #5442
For GH issues: closes #5442

Showcase (Optional)

If there is a UI change include the screenshots with before and after state.
If new feature is being introduced, include the link to demo recording.

Checklist

  • Code in this PR is covered by automated tests (Unit tests, E2E tests)
  • My changes generate no new warnings
  • [] I have reviewed my own code
  • I have filled out all required sections
  • I have tested my changes on the preview link
  • Approver of this PR confirms that the changes are tested on the preview link

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2026

⚠️ No Changeset found

Latest commit: 0116484

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
appkit-basic-html Ready Ready Preview, Comment Jan 16, 2026 6:18pm
appkit-demo Ready Ready Preview, Comment Jan 16, 2026 6:18pm
appkit-gallery Ready Ready Preview, Comment Jan 16, 2026 6:18pm
appkit-headless-sample-app Ready Ready Preview, Comment Jan 16, 2026 6:18pm
appkit-laboratory Ready Ready Preview, Comment Jan 16, 2026 6:18pm
10 Skipped Deployments
Project Deployment Review Updated (UTC)
appkit-basic-example Ignored Ignored Jan 16, 2026 6:18pm
appkit-basic-sign-client-example Ignored Ignored Jan 16, 2026 6:18pm
appkit-basic-up-example Ignored Ignored Jan 16, 2026 6:18pm
appkit-ethers5-bera Ignored Ignored Jan 16, 2026 6:18pm
appkit-nansen-demo Ignored Ignored Jan 16, 2026 6:18pm
appkit-vue-solana Ignored Ignored Jan 16, 2026 6:18pm
appkit-wagmi-cdn-example Ignored Ignored Jan 16, 2026 6:18pm
ethereum-provider-wagmi-example Ignored Ignored Jan 16, 2026 6:18pm
next-wagmi-solana-bitcoin-example Ignored Ignored Jan 16, 2026 6:18pm
vue-wagmi-example Ignored Ignored Jan 16, 2026 6:18pm

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Visual Regression Test Results ✅ Passed

⚠️ 15 visual change(s) detected

Chromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=677
Storybook Preview: https://6493191bf4b10fed8ca7353f-bazpnqiebo.chromatic.com/

👉 Please review the visual changes in Chromatic and accept or reject them.

@rtomas rtomas requested a review from 0xmkh January 15, 2026 21:07
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

📦 Bundle Size Check

All bundles are within size limits

📊 View detailed bundle sizes

> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit


> size-limit

@reown/appkit - Main Entry
Size limit:   80 kB
Size:         75.25 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 440 ms   on Snapdragon 410
Total time:   2 s
@reown/appkit/react
Size limit:   235 kB
Size:         233.1 kB with all dependencies, minified and gzipped
Loading time: 4.6 s    on slow 3G
Running time: 943 ms   on Snapdragon 410
Total time:   5.5 s
@reown/appkit/vue
Size limit:   80 kB
Size:         75.25 kB with all dependencies, minified and gzipped
Loading time: 1.5 s    on slow 3G
Running time: 324 ms   on Snapdragon 410
Total time:   1.8 s
@reown/appkit-scaffold-ui
Size limit:   220 kB
Size:         213.13 kB with all dependencies, minified and gzipped
Loading time: 4.2 s     on slow 3G
Running time: 756 ms    on Snapdragon 410
Total time:   5 s
@reown/appkit-ui
Size limit:   500 kB
Size:         13.16 kB with all dependencies, minified and gzipped
Loading time: 258 ms   on slow 3G
Running time: 145 ms   on Snapdragon 410
Total time:   402 ms

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 78.65% 39404 / 50100
🔵 Statements 78.65% 39404 / 50100
🔵 Functions 76.32% 4246 / 5563
🔵 Branches 86.71% 9576 / 11043
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/ui/src/components/wui-icon/index.ts 100% 100% 77.14% 100%
Generated in workflow #16734 for commit 0116484 by the Vitest Coverage Report Action

@rtomas
Copy link
Contributor Author

rtomas commented Jan 16, 2026

New one
image
Old
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SVG icons render with empty width/height attributes causing console errors

2 participants