Skip to content

Conversation

@vmikhailenko
Copy link
Collaborator

  • Both services are created with Java version set to Java 17
  • The manifest.yaml is changed so it is now specifies Java 17, disables Spring Boot Auto Configuration (buildpack is quite loud about it being deprecated) and explicitly sets the cloud profile for Spring Boot.
  • xs-security.json is updated with "oauth2-configuration". In default data center offered for trial accounts it is mandatory.

@vmikhailenko vmikhailenko changed the title Cap java 2.0 CAP Java 2.0 Jul 6, 2023
@vmikhailenko
Copy link
Collaborator Author

vmikhailenko commented Jul 6, 2023

Side note: the link we offer as a guide to create SAP HANA is a little newer than we need. I followed it https://developers.sap.com/tutorials/hana-cloud-mission-trial-2.html and got an error at the step where we need to deploy the database there. It seems either we need to do something in addition with this new tools plan.

I tried simpler way to create SAP HANA via hana plan. This is working, one must to allow access to all IPs.

Side note #2: The link

Congratulations, you have added the SAP HANA Cloud entitlements and subscribed to the multi-environment tools. You now have the ability to provision your trial instance of SAP HANA Cloud and start your journey.

seems to be broken.

@vmikhailenko
Copy link
Collaborator Author

The new guide for HANA Cloud creation is a little more complex, but everything worked in the end.

Copy link
Collaborator

@rjayasinghe rjayasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 42 to 46
```Shell/Bash
mvn -B archetype:generate -DarchetypeArtifactId=cds-services-archetype -DarchetypeGroupId=com.sap.cds \
-DarchetypeVersion=RELEASE -DjdkVersion=11 \
-DarchetypeVersion=RELEASE -DjdkVersion=17 \
-DgroupId=com.sap.cap -DartifactId=bookstore
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also use cds init bookstore --add java here.

buildpacks:
- java_buildpack
env:
JBP_CONFIG_OPEN_JDK_JRE: '{ jre: { version: 17.+ }}'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this get sap machine or just the generic OpenJDK?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do both work on CF?

@renejeglinsky
Copy link
Owner

renejeglinsky commented Jul 11, 2023

Side note: the link we offer as a guide to create SAP HANA is a little newer than we need. I followed it https://developers.sap.com/tutorials/hana-cloud-mission-trial-2.html and got an error at the step where we need to deploy the database there. It seems either we need to do something in addition with this new tools plan.

I tried simpler way to create SAP HANA via hana plan. This is working, one must to allow access to all IPs.

Side note #2: The link

Congratulations, you have added the SAP HANA Cloud entitlements and subscribed to the multi-environment tools. You now have the ability to provision your trial instance of SAP HANA Cloud and start your journey.

seems to be broken.

Meanwhile the link seems fixed. It essentially is the same link as in your first sentence.

Did you make it also work using the tools plan?

@vmikhailenko
Copy link
Collaborator Author

vmikhailenko commented Jul 11, 2023

Side note: the link we offer as a guide to create SAP HANA is a little newer than we need. I followed it https://developers.sap.com/tutorials/hana-cloud-mission-trial-2.html and got an error at the step where we need to deploy the database there. It seems either we need to do something in addition with this new tools plan.
I tried simpler way to create SAP HANA via hana plan. This is working, one must to allow access to all IPs.
Side note #2: The link

Congratulations, you have added the SAP HANA Cloud entitlements and subscribed to the multi-environment tools. You now have the ability to provision your trial instance of SAP HANA Cloud and start your journey.

seems to be broken.

Meanwhile the link seems fixed. It essentially is the same link as in your first sentence.

Did you make it also work using the tools plan?

Yes. Maybe it is better to add direct references to our tutorial. The procedure is scattered across three different tutorials and is rather hard to figure out unless you know what to do.

@renejeglinsky
Copy link
Owner

...

Yes. Maybe it is better to add direct references to our tutorial. The procedure is scattered across three different tutorials and is rather hard to figure out unless you know what to do.

Sure let's try to do it. Do you still have the places and information in mind and can write it up?

Anyway, we can do that in another branch and merge this one to publish it, right?

You first need to provision your SAP HANA Cloud instance, which is a prerequisite to later on create a SAP HANA HDI Container to deploy your database artifacts to.

1. Follow the tutorial [Provision an Instance of SAP HANA Cloud](hana-cloud-mission-trial-2). Use `bookstore-db` as the name of your database and make sure to allow access to your SAP HANA Cloud from all IPs.
1. Follow the tutorial [Provision an Instance of SAP HANA Cloud](hana-cloud-mission-trial-2). Use `bookstore-db` as the name of your database. Make sure to allow access to your SAP HANA Cloud from all IPs and that instance of the SAP HANA you have created is mapped to your subaccount and space where you working with this tutorial.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried that in a trial account? I guess this is not needed in trial accounts, which is the assumption for this tutorial.

@renejeglinsky renejeglinsky merged commit 113f1be into master Jul 12, 2023
renejeglinsky pushed a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants