-
Notifications
You must be signed in to change notification settings - Fork 0
CAP Java 2.0 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAP Java 2.0 #3
Conversation
|
Side note: the link we offer as a guide to create SAP HANA is a little newer than we need. I followed it https://developers.sap.com/tutorials/hana-cloud-mission-trial-2.html and got an error at the step where we need to deploy the database there. It seems either we need to do something in addition with this new I tried simpler way to create SAP HANA via Side note #2: The link
seems to be broken. |
|
The new guide for HANA Cloud creation is a little more complex, but everything worked in the end. |
rjayasinghe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| ```Shell/Bash | ||
| mvn -B archetype:generate -DarchetypeArtifactId=cds-services-archetype -DarchetypeGroupId=com.sap.cds \ | ||
| -DarchetypeVersion=RELEASE -DjdkVersion=11 \ | ||
| -DarchetypeVersion=RELEASE -DjdkVersion=17 \ | ||
| -DgroupId=com.sap.cap -DartifactId=bookstore | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also use cds init bookstore --add java here.
| buildpacks: | ||
| - java_buildpack | ||
| env: | ||
| JBP_CONFIG_OPEN_JDK_JRE: '{ jre: { version: 17.+ }}' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this get sap machine or just the generic OpenJDK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do both work on CF?
Meanwhile the link seems fixed. It essentially is the same link as in your first sentence. Did you make it also work using the |
Yes. Maybe it is better to add direct references to our tutorial. The procedure is scattered across three different tutorials and is rather hard to figure out unless you know what to do. |
|
...
Sure let's try to do it. Do you still have the places and information in mind and can write it up? Anyway, we can do that in another branch and merge this one to publish it, right? |
| You first need to provision your SAP HANA Cloud instance, which is a prerequisite to later on create a SAP HANA HDI Container to deploy your database artifacts to. | ||
|
|
||
| 1. Follow the tutorial [Provision an Instance of SAP HANA Cloud](hana-cloud-mission-trial-2). Use `bookstore-db` as the name of your database and make sure to allow access to your SAP HANA Cloud from all IPs. | ||
| 1. Follow the tutorial [Provision an Instance of SAP HANA Cloud](hana-cloud-mission-trial-2). Use `bookstore-db` as the name of your database. Make sure to allow access to your SAP HANA Cloud from all IPs and that instance of the SAP HANA you have created is mapped to your subaccount and space where you working with this tutorial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried that in a trial account? I guess this is not needed in trial accounts, which is the assumption for this tutorial.
manifest.yamlis changed so it is now specifies Java 17, disables Spring Boot Auto Configuration (buildpack is quite loud about it being deprecated) and explicitly sets thecloudprofile for Spring Boot.xs-security.jsonis updated with"oauth2-configuration". In default data center offered for trial accounts it is mandatory.