Conversation
|
@mikoczy please add description to your PR. Why do you need to remove this validation check? This transformation to lower case was added so we don't register two users with same email address - eg. john@gmail.com and JOHN@gmail.com. Gmail (and most of the email providers) is not case sensitive so these emails are actually same account. If you have valid use case we can move this validation to some kind of validation provider which could be disabled. But we don't want to remove it. |
|
@markoph sorry, it is a follow up to an older pr (#6).. mysql is case insensitive too, so the use case you described, cannot happen... on the other hand, when using LOWER, mysql will not use the email index, so if the users table is big enough, this query can be very slow, timeouts can happen, when adding a user through api.. |
|
@mikoczy FYI: your commit was merged internally and changes will be part of next release. |
|
@markoph great, thanks |
MySQL is case insensitive. And when LOWER is used, MySQL will not use the email index. #14
1bb0b05 to
8e046aa
Compare
No description provided.