feat: remove unused costing models #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes unused costing models from being taken in to consideration when building tiles. It also prevents them from being used when making routing requests.
sgoel
commented
Dec 23, 2024
| custom_model_files: [tramtrain.json, 15kv-ac_750v-dc.json, gauge_1435.json, preferred_direction.json] | ||
| - name: all_tracks | ||
| turn_costs: | ||
| vehicle_types: [train, tram, light_rail, subway] |
Collaborator
Author
There was a problem hiding this comment.
This list is not meant to be in sync with the paper doc. See line 19 in this file:
vehicle_types: [train, tram, light_rail, subway] (vehicle types used for vehicle-specific turn restrictions)
|
thanks for ticket link too 🍧 👍 |
chelsey
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused costing models from being taken in to consideration when building tiles.
It also prevents them from being used when making routing requests.
https://ridewithvia.atlassian.net/browse/REM-8651