Fix the spinner for the newsfeed example used in the Relay tutorial#329
Merged
captbaritone merged 1 commit intomainfrom Apr 9, 2025
Merged
Fix the spinner for the newsfeed example used in the Relay tutorial#329captbaritone merged 1 commit intomainfrom
captbaritone merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is to fix the spinner used in the Relay tutorial example. The spinner is being used throughout the app, but has a
position: absoluteto try and center is when the main app is loading. This breaks the spinner for the hovercard and other places it's used. I updated the spinner to just be horizontally centered without aposition: absoluteand wrapped it for the main app spinner.Before:
After: