Update StoryCommentsSection.tsx to accurately reflect Relay tutorial#327
Open
danielstocks wants to merge 1 commit intorelayjs:mainfrom
Open
Update StoryCommentsSection.tsx to accurately reflect Relay tutorial#327danielstocks wants to merge 1 commit intorelayjs:mainfrom
danielstocks wants to merge 1 commit intorelayjs:mainfrom
Conversation
Following the steps in the [Connections & Pagination](https://relay.dev/docs/next/tutorial/connections-pagination/#implementing-load-more-comments) part of the Relay Tutorial is clearly states that: > At this point, you should see up to three comments on each story. Some stories have more than three comments, and these will show a "Load more" button, although it isn't hooked up yet. But the example only loads 1 comments, and there is no "Load more" button present. The tutorial assumes that this code is already present and that is confusing to the reader. In this PR I've updated `StoryCommentsSection.tsx` to reflect the code examples & instructions in the tutorial. Thanks!
danielstocks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the steps in the Connections & Pagination part of the Relay Tutorial is clearly states that:
But the example only loads 1 comments, and there is no "Load more" button present. The tutorial assumes that this code is already present and that is confusing to the reader.
In this PR I've updated
StoryCommentsSection.tsxto reflect the code examples & instructions in the tutorial.Thanks!