[Next 13] Fix QueryResponseCache for Preloaded Queries#292
[Next 13] Fix QueryResponseCache for Preloaded Queries#292baristikir wants to merge 2 commits intorelayjs:mainfrom
Conversation
|
Hi @baristikir! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| children: React.ReactNode; | ||
| }) { | ||
| const environment = getCurrentEnvironment(); | ||
| const environment = createEnvironment(); |
There was a problem hiding this comment.
Noticed that this could potentially result in an infinite rerender loop.
env-infinite-rerender.mov
|
Recent changes might also fix #288 |
2 participants
PR related to issue #291
Issue:
QueryResponseCachewhich results into another network fetch initiated from theusePreloadedQueryresponseCachebeing null in client component**Code related to response cache was copied from: https://github.com/Pokeyo-AB/relay-starter-next/blob/main/lib/relay/environment.ts