Open
Conversation
voideanvalue
suggested changes
Mar 5, 2022
Contributor
voideanvalue
left a comment
There was a problem hiding this comment.
Thanks for the pull request @fanny. I like the updated structure.
The files in src/__generated__/ are build artifacts created by relay-compiler and cannot be moved. I can merge this after those changes are reverted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to improve our example comprehension, I've decided to group components related into modules. I know this is subject of judgment, but at least I saw this organization pattern many times, so I believe it's well adopted. Now the modules are organized as follows:
I'm totally open to closing this if y'll think it's not useful or change to another interesting organizational structure, so feel free to suggest things.
├── public ├── schema └── src ├── __generated__ ├── components ├── hooks ├── pages │ ├── IssueDetail │ │ └── __generated__ │ └── Issues │ └── __generated__ └── routingcomponents: Contains foundational components used by other pages (e.g ErrorBoundary, SuspenseImage)hooks: Contains all hooks available on this projectpages: Contains the modules for our routes and their own componentsI've also created a new component called
IssueDetailCommentbecause we were copying-paste its content onIssueDetailCommentsandIssueDetailRoot