1 - Broadcast - Slog wrapper #198
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The broadcast implementation greatly relies on the logging feature - Type safety in logs is encouraged by the wrapper
aleksander-vedvik
changed the title
meling
approved these changes
Jan 11, 2025
Member
meling
left a comment
meling
left a comment
There was a problem hiding this comment.
Thanks for the PRs :-)
BroadcastID and MachineID are the only "labels" with capitalization (first letter). Does this have a particular significance, or should it be lower-cased to match the other labels?
Collaborator
Author
Nope, they can be lower-cased 👌 |
Contributor
|
Here's the code health analysis summary for commits Analysis Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The broadcast code heavily relies on the logging wrapper. Hence, it is included first.