updates emit to work with scoped vars#8
Open
matthewkastor wants to merge 3 commits intorefactoror:masterfrom
Open
updates emit to work with scoped vars#8matthewkastor wants to merge 3 commits intorefactoror:masterfrom
matthewkastor wants to merge 3 commits intorefactoror:masterfrom
Conversation
since storedVars has to be block scoped now, emit and others access storedVarsGlobal to do the same thing they used to. Also, evalWithVars was defined twice in here, in exactly the same way, so I removed one of them.
I forgot to add this in earlier. storedVarsGlobal only exists in a dev branch of SelBlocks. With this code in place SelBench will continue to work as it did before.
This didn't come up in testing selbench because there isn't a test for deleteVar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These updates are related to refactoror/SelBlocks#19 You'll need them in order to run all the preexisting and new tests for SelBlocks that are in that branch.
Since storedVars has to be block scoped now, emit and others access
storedVarsGlobal to do the same thing they used to.
Also, evalWithVars was defined twice in here, in exactly the same way,
so I removed one of them.