Replication troubleshooting: replication-inspect command#121
Open
agoncharov-reef wants to merge 2 commits intomasterfrom
Open
Replication troubleshooting: replication-inspect command#121agoncharov-reef wants to merge 2 commits intomasterfrom
agoncharov-reef wants to merge 2 commits intomasterfrom
Conversation
agoncharov-reef
force-pushed
the
replication-troubleshooting
branch
from
755c931 to
efdaca6
Compare
ppolewicz
reviewed
Aug 16, 2022
| key = None | ||
| for key, value in rows: | ||
| self._print(' ' * 2 + key + ': ' + value) | ||
| if not key: # loop was not entered |
There was a problem hiding this comment.
Suggested change
| if not key: # loop was not entered | |
| if key is None: # loop was not entered |
because an empty key will mess with this
There was a problem hiding this comment.
also PEP8 says if you want to check if something is None, use if key is None, not if not key:
agoncharov-reef
force-pushed
the
replication-troubleshooting
branch
from
efdaca6 to
869596b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.