Skip to content

Conversation

@Cheesebaron
Copy link
Collaborator

@Cheesebaron Cheesebaron commented Oct 6, 2025

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

After fist dismiss HudWindow gets nulled out and does not allow any more huds to be displayed for that Window as a ProgressHud reference is being kept per Window.
Since many phone Apps are single Window, then the ProgressHud will stop working if its internal reference to the HudWindow is nulled out.

This regression was introduced in #117

💥 Does this PR introduce a breaking change?

🐛 Recommendations for testing

Call any Show() method multiple times

📝 Links to relevant issues/docs

#117
Fixes #121

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines
  • Relevant documentation was updated

@Cheesebaron Cheesebaron added the bug label Oct 6, 2025
@Cheesebaron Cheesebaron requested a review from Copilot October 6, 2025 19:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fix regression so the HUD can be displayed multiple times by preserving the window reference instead of nulling it after dismiss.

  • Stop nulling HudWindow in RemoveHud to allow subsequent Show() calls.
  • Keep status bar update call intact.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Cheesebaron Cheesebaron merged commit 288bb7a into main Oct 6, 2025
1 check passed
@Cheesebaron Cheesebaron deleted the bugfix/gh-121-dont-null-window branch October 6, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dialogs can only be showed once in v2.2.2

2 participants