Merged
Conversation
Previously all null-terminated string readers used `byte as char`, which treats each byte as a Latin-1 code point. This corrupts any multi-byte UTF-8 text (e.g. Chinese/Japanese item names in EXD sheets). Replace every occurrence with proper UTF-8 decoding via `String::from_utf8`, and extract two reusable helpers in common_file_operations: - `read_null_terminated_utf8` (reader-based) - `null_terminated_utf8` (byte-slice-based) Also fix `dic.rs` where `as u8 as char` truncated full Unicode code points to 8 bits. Add 8 unit tests covering ASCII, CJK, empty, and invalid UTF-8 inputs.
redstrate
approved these changes
Feb 13, 2026
Owner
redstrate
left a comment
redstrate
left a comment
There was a problem hiding this comment.
Thanks! Didn't think it would be that easy, also tested it locally with Novus and it prints the correct Japanese text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #33
Previously all null-terminated string readers used
byte as char, which treats each byte as a Latin-1 code point. This corrupts any multi-byte UTF-8 text (e.g. Chinese/Japanese item names in EXD sheets).Replace every occurrence with proper UTF-8 decoding via
String::from_utf8, and extract two reusable helpers in common_file_operations:read_null_terminated_utf8(reader-based)null_terminated_utf8(byte-slice-based)Also fix
dic.rswhereas u8 as chartruncated full Unicode code points to 8 bits.Add 8 unit tests covering ASCII, CJK, empty, and invalid UTF-8 inputs.