Skip to content

Modernize a bit #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
redbluegreenhat wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modernize a bit #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions includes/Hooks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,16 @@
use MediaWiki\Revision\RevisionRecord;
use Wikimedia\Rdbms\IConnectionProvider;

class Hooks implements
final class Hooks implements
BeforePageDisplayHook,
GetMagicVariableIDsHook,
PageDeleteCompleteHook,
ParserGetVariableValueSwitchHook
{

private $connectionProvider;

public function __construct(
IConnectionProvider $connectionProvider
) {
$this->connectionProvider = $connectionProvider;
}
private IConnectionProvider $connectionProvider
) {}

public function onBeforePageDisplay( $out, $skin ): void {
$out->addModules( 'ext.hitcounters2.incrementcounter' );
Expand Down
2 changes: 1 addition & 1 deletion includes/Installer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use MediaWiki\Installer\Hook\LoadExtensionSchemaUpdatesHook;

class Installer implements LoadExtensionSchemaUpdatesHook {
final class Installer implements LoadExtensionSchemaUpdatesHook {

public function onLoadExtensionSchemaUpdates( $updater ) {
$dbType = $updater->getDB()->getType();
Expand Down
17 changes: 5 additions & 12 deletions includes/Rest/Handler/RestIncrementCounter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,16 @@
use Wikimedia\ParamValidator\ParamValidator;
use Wikimedia\Rdbms\IConnectionProvider;

/*
/**
* Increments the hit counter for the specified page ID
* POST /hitcounters2/v0/increment/{id}
*/
class RestIncrementCounter extends SimpleHandler {

private $connectionProvider;

private $wikiPageFactory;
final class RestIncrementCounter extends SimpleHandler {

public function __construct(
IConnectionProvider $connectionProvider,
WikiPageFactory $wikiPageFactory
) {
$this->connectionProvider = $connectionProvider;
$this->wikiPageFactory = $wikiPageFactory;
}
private IConnectionProvider $connectionProvider,
private WikiPageFactory $wikiPageFactory
) {}

public function run( int $pageID ) {
$body = $this->getValidatedBody();
Expand Down
7 changes: 2 additions & 5 deletions includes/Specials/SpecialResetHitCounter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,13 @@
use MediaWiki\Title\Title;
use Wikimedia\Rdbms\IConnectionProvider;

class SpecialResetHitCounter extends FormSpecialPage {

private $connectionProvider;
final class SpecialResetHitCounter extends FormSpecialPage {

private $page;

public function __construct(
IConnectionProvider $connectionProvider
private IConnectionProvider $connectionProvider
) {
$this->connectionProvider = $connectionProvider;
parent::__construct( 'ResetHitCounter', 'hitcounters2-resetcounter' );
}

Expand Down