Repo clean up and retiring old code#119
Open
KasparByrne wants to merge 4 commits intoredbackoperations:mainfrom
Open
Repo clean up and retiring old code#119KasparByrne wants to merge 4 commits intoredbackoperations:mainfrom
KasparByrne wants to merge 4 commits intoredbackoperations:mainfrom
Conversation
-Now uses Drivers/lib/mqtt_client.py MQTT client code instead of own.
-Rewrote most code to use event listening for button presses instead of looping & sleeping
-Moved button code into own driver folder: button_control
-Created new MQTT topic - bike/{ID}/button - for button communication.
-Now uses parsed arguments from script with defaulting to environment variables rather than hardcoded values.
-Changed to use report sub-topic instead of control sub-topic as the buttons only "sense"
- turns out there was a much cleaner way to import the mqtt_client from lib.
- Moved old research into archive folder. - Moved old drivers that were no longer relevant to archive folder. - Moved unused Unity project in IoT repo (believe this may be the old game which is no longer being developed) to archive folder. - Moved remote connect code, due to breaking and being undocumented, to archive folder. - Moved workout drivers into own sub folder in Drivers folder since a lot of them are no longer relevant but we may want to take inspiration from them for the mobile app. **This looks super scary but everything is being preserved and just dumped into the archive folder for later exploration or use if needed.** The repo is currently very cluttered with redundant and abandoned projects and research. This makes it very difficult to discover relevant code when combined with the lack of documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved old research into archive folder.
Moved old drivers that were no longer relevant to archive folder.
Moved unused Unity project in IoT repo (believe this may be the old game which is no longer being developed) to archive folder.
Moved remote connect code, due to breaking and being undocumented, to archive folder.
Moved workout drivers into own sub folder in Drivers folder since a lot of them are no longer relevant but we may want to take inspiration from them for the mobile app.
This looks super scary but everything is being preserved and just dumped into the archive folder for later exploration or use if needed. The repo is currently very cluttered with redundant and abandoned projects and research. This makes it very difficult to discover relevant code when combined with the lack of documentation.