Use assemblePrereleaseRelease for building prerelease #2365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more explicit that way. This also adds missing `MDL_API_KEY` to archive build, which seems was missed. Additionally, this also removes running `build` manually, it's unnecessary now. In the future, we can also probably remove `androidSourcesJar` and `sources.jar` from releases, every since the library split it really hasnt been useful as we don't even include library sources in it, so we don't actually need it. But for now, we can leave it. I also plans to have `makeJar` auto run with the release build type to auto include for all releases, including stable so we can have `classes.jar` for stable releases as well (though it would still need included in release artifacts still). We can also create a new workflow triggered by `workflow_dispatch` for manually triggering to streamline creating stable releases and auto include this as well. Those are just some things I'm planning for the future (if even wanted), but this is just a start for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's more explicit that way.
This also adds missing
MDL_API_KEYto archive build, which seems was missed.Additionally, this also removes running
buildmanually, it's unnecessary now (since #2261). In the future, we can also probably removeandroidSourcesJarandsources.jarfrom releases, ever since the library split it really hasn't been useful as we don't even include library sources in it, so we don't actually need it (unless it is still needed for some usage I'm not clear on, which is very possible). But for now, we can leave it. I also plans to havemakeJarauto run with the release build type to auto include for all releases, including stable so we can haveclasses.jarfor stable releases as well (though it would still need included in release artifacts still). We can also create a new workflow triggered byworkflow_dispatchfor manually triggering to streamline creating stable releases and auto include this as well. Those are just some things I'm planning for the future (if even wanted), but this is just a start for that.