Skip to content

Conversation

@Luna712
Copy link
Contributor

@Luna712 Luna712 commented Dec 21, 2025

No description provided.

@diogob003
Copy link
Contributor

As far as I know we do have 4 "flavors"

  • Green 🟢 com.lagradost.cloudstream3.prerelease.debug
  • Red 🔴 com.lagradost.cloudstream3.prerelease
  • Green 🟢 com.lagradost.cloudstream3.debug
  • Blue 🔵 com.lagradost.cloudstream3

If I'm not mistaken, the default variant for Android Studio is com.lagradost.cloudstream3.debug and the variant used on pr build is com.lagradost.cloudstream3.prerelease.debug

It might be worthwhile to include lint checking in both debugging variants, so that the developer can find and fix bugs before submitting a pull request.

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 21, 2025

As far as I know we do have 4 "flavors"

  • Green 🟢 com.lagradost.cloudstream3.prerelease.debug
  • Red 🔴 com.lagradost.cloudstream3.prerelease
  • Green 🟢 com.lagradost.cloudstream3.debug
  • Blue 🔵 com.lagradost.cloudstream3

If I'm not mistaken, the default variant for Android Studio is com.lagradost.cloudstream3.debug and the variant used on pr build is com.lagradost.cloudstream3.prerelease.debug

It might be worthwhile to include lint checking in both debugging variants, so that the developer can find and fix bugs before submitting a pull request.

Good idea, I missed that part. It is now done.

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 22, 2025

For the record I did it like this with androidComponents instead of checking both assemblePrereleaseDebug and assembleStableDebug just because 1) this seemed cleaner to me, 2) is more future proofed if we add some other flavor at some point or something, and 3) is more designed for circumstances like this.

@Luna712
Copy link
Contributor Author

Luna712 commented Dec 22, 2025

As far as I know we do have 4 "flavors"

  • Green 🟢 com.lagradost.cloudstream3.prerelease.debug
  • Red 🔴 com.lagradost.cloudstream3.prerelease
  • Green 🟢 com.lagradost.cloudstream3.debug
  • Blue 🔵 com.lagradost.cloudstream3

If I'm not mistaken, the default variant for Android Studio is com.lagradost.cloudstream3.debug and the variant used on pr build is com.lagradost.cloudstream3.prerelease.debug

It might be worthwhile to include lint checking in both debugging variants, so that the developer can find and fix bugs before submitting a pull request.

@diogob003

Just a small correction here though, we technically only have 2 "flavors" (stable and prerelease) and 2 build types, release and debug. That means that for both flavors, can have the combination of any of the build type, stableDebug, prereleaseDebug, stableRelease, prereleaseRelease, what I forgot was for some reason, android studio builds stableRelease by default, and didn't consider that one, which ironically was the entire point of this PR to work locally the same as PRs here, as otherwise we could just add lint to the workflow to achieve the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants