Use withStyledAttributes #2305
Open
Use withStyledAttributes #2305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is safer against memory leaks and doesn't require calling `recycle()`. This also refactors methods in UIHelper, `getResourceColor`, `colorFromAttribute`, and `adjustAlpha` in order to only call `withStyledAttributes` once and use the other two methods as shortcuts in `getResourceColor`.
Collaborator
|
Good pull request, but I do not want to cause merge issues with #2037, So I will leave this to after the download PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is safer against memory leaks and doesn't require calling
recycle().This also refactors methods in UIHelper,
getResourceColor,colorFromAttribute, andadjustAlphain order to only callwithStyledAttributesonce and use the other two methods as shortcuts ingetResourceColor.