Support queue::ext_oneapi_get_state() with native recording and fix urQueueIsGraphCaptureEnabledExp#398
Draft
mmichel11 wants to merge 2 commits intopablo/graph-native-recording-prototype-v2-rebasefrom
Conversation
kswiecicki
approved these changes
Jan 27, 2026
reble
approved these changes
Jan 27, 2026
Collaborator
Author
|
Opened a PR in intel/llvm for the UR fix + simple fork-join test: intel#21145 |
Collaborator
Author
|
Some more context on the last commit: NEO has changed fork-join recording behavior with L0 graph.
With the new behavior, we should be able to just flip the assert value check but it changes with driver version and is messy to handle, so just asserting that both queues are executing after Queue1 stops recording makes the most sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queue::ext_oneapi_get_state()does not work for two reasons:urQueueIsGraphCaptureEnabledExp. If the result is not success, we know we are not recording as the API is unsupported. Otherwise, we check the result.urQueueIsGraphCaptureEnabledExpdoes not function properly as it does not handle command list fork-join. We should fix this by querying the L0 API instead of duplicating the logic throughout UR to track queue state transition.