Add local memory parameter update functionality to sycl graphs.#382
Draft
fabiomestre wants to merge 6 commits intosyclfrom
Draft
Add local memory parameter update functionality to sycl graphs.#382fabiomestre wants to merge 6 commits intosyclfrom
fabiomestre wants to merge 6 commits intosyclfrom
Conversation
fabiomestre
commented
Dec 31, 2024
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
EwanC
reviewed
Jan 6, 2025
Collaborator
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
Comments are all trivial editorial details from a pass reading this over
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
Bensuo
reviewed
Jan 6, 2025
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
EwanC
reviewed
Jan 17, 2025
Collaborator
EwanC
left a comment
EwanC
left a comment
There was a problem hiding this comment.
This looks good, we could maybe also have an examples in sycl/doc/syclgraph/SYCLGraphUsageGuide.md to help show the new dynamic classes and aid stakeholder review.
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
EwanC
reviewed
Jan 17, 2025
sycl/doc/extensions/experimental/sycl_ext_oneapi_graph.asciidoc
Outdated
Show resolved
Hide resolved
Updates the sycl graph specification to add the dynamic_accessor, dynamic_local_accessor and dynamic_work_group_memory classes. This adds the required functionality to support updating local memory parameters to sycl graph kernel nodes. Additionally, it also moves the accessor update functionality from the dynamic_parameter class to the new dynamic_accessor class. This improves the cohesion of the API and removes the need to use placeholder accessors when updating buffer arguments in sycl graphs.
fabiomestre
force-pushed
the
fabio/local_accessor_update_spec
branch
from
670e1ea to
372f06f
Compare
added 2 commits
February 14, 2025 12:55
- Specify new usage for dynamic parameters after compiler support is added. - Update get() function to be used only in device code. - Remove set_arg() overloads - Clarify template parameters limitations and add static_asserts to class definition. - Fix wording of work_group_memory parameters.
EwanC
reviewed
Feb 17, 2025
|
|
||
| sycl_ext::dynamic_parameter dynParam(myGraph, ptrX); | ||
|
|
||
| sycl_ext::node kernelNode = myGraph.add([&](handler& cgh) { |
Collaborator
There was a problem hiding this comment.
variable is called defined as Graph not myGraph
| sycl_ext::dynamic_parameter dynParam(myGraph, ptrX); | ||
|
|
||
| sycl_ext::node kernelNode = myGraph.add([&](handler& cgh) { | ||
| CGH.parallel_for(range<1>(Size), [=](item<1> Id) { |
Collaborator
There was a problem hiding this comment.
variable is defined as cgh not CGH
added 3 commits
February 24, 2025 18:26
Updates the dynamic parameter class to require underlying type to be device copyable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the sycl graph specification to add the dynamic_accessor, dynamic_local_accessor and dynamic_work_group_memory classes.
This adds the required functionality to support updating local memory parameters to sycl graph kernel nodes.
Additionally, it also moves the accessor update functionality from the dynamic_parameter class to the new dynamic_accessor class. This improves the cohesion of the API and removes the need to use placeholder accessors when updating buffer arguments in sycl graphs.